aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

refactored pre-check #47

Closed ammokhov closed 4 years ago

ammokhov commented 4 years ago

Issue #, if available: https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-logs/issues/39

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

miparnisari commented 4 years ago

I ran integration tests with this PR:

image

I also ran them with this PR+removing the Read after the Create & Update operations:

image

ammokhov commented 4 years ago

I ran integration tests with this PR:

I also ran them with this PR+removing the Read after the Create & Update operations:

latest change results of 7 integ tests:

SUCCESSFUL in 2m 49s
miparnisari commented 4 years ago
============================================== short test summary info ==============================================
FAILED handler_update.py::contract_update_create_only_property - UnboundLocalError: local variable 'created_model'...
FAILED handler_update.py::contract_update_non_existent_resource - AssertionError: status should be FAILED
ERROR handler_delete.py::contract_delete_read - AssertionError: assert 'resourceModel' not in {'callbackDelaySecon...
ERROR handler_delete.py::contract_delete_list - AssertionError: assert 'resourceModel' not in {'callbackDelaySecon...
ERROR handler_delete.py::contract_delete_update - AssertionError: assert 'resourceModel' not in {'callbackDelaySec...
ERROR handler_delete.py::contract_delete_delete - AssertionError: assert 'resourceModel' not in {'callbackDelaySec...
ERROR handler_delete.py::contract_delete_create - AssertionError: assert 'resourceModel' not in {'callbackDelaySec...
===================== 2 failed, 7 passed, 1 skipped, 9 warnings, 5 errors in 152.70s (0:02:32) ======================
One or more contract tests failed

We need to fix this before publishing the type