Add tag support to LogGroup resource

[gruebel]

Fixes aws-cloudformation/aws-cloudformation-coverage-roadmap#77

Description of changes: I added the possibility to add tags to the LogGroup resource.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[wbingli]

Thanks for your contribution. We are prioritizing this PR review.

[petewilcock]

+1 on this PR, we're awaiting this functionality 💯

[gruebel]

@PatMyron is there anything else I should change or more feedback?

[gruebel]

@wbingli would be great to get some feedback for my new changes 😄

[jaglade]

Is there any update on this PR? We are eagerly awaiting this functionality.

[tata9001]

Any update on this PR?

[Aleksandr-Filichkin]

Any update on this?

[vitali-pozniak]

+1

[mgmarino]

It'd be great to have input from either the reviewers or @gruebel (who has already put in a lot of work here, thanks!) about whether help from the community is desired to get this over the finish line. This is a very important feature improvement.

[JoryUK]

+1

[wbingli]

@sfbaker7 Any comment to this PR? I have only one comment here (https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-logs/pull/53#discussion_r568077119) to address.

[gruebel]

sorry, everyone. I totally forgot about my PR 🙈

@wbingli I added the silent fail behaviour for add and remove tags, when trying to update a log group. Tagging permissions are not needed when creating a log group with tags.

[wbingli]

@gruebel Thanks for your contribution. Will merge it once we have other reviewer approve it.

[shoddyknight]

I am eagerly awaitiing this being merged so I can tag and find my cfn-init logs easily

[samjarrett]

Is this still yet to be deployed? It definitely isn't documented and doesn't work if you specify Tags: as a property...

[sfbaker7]

Hi, we are expecting this to be available in all regions by the end of next week. Documentation change will follow after

Will update this thread once deployed, apologies for the delay!

[glc-froussel]

Hello there, any update on this ?

[bool3012]

Any update?? This feature still doesn't work, at least in eu regions..

[felixfang]

Hi this is Felix from AWS, to add support of tags, our team need to go through security review to release it. We are currently working on the review.

[bencovi]

Hi @felixfang - any updates?

[felixfang]

Hi we are still working on the security review. We are aiming to have it ready in September

[felixfang]

Hi Sam, just and update. The security review is in good progress, we just need some more weeks to close it so we can pull your request into our code. We will try complete Tag support in Oct. Sorry for delaying on this.

[Karthi96]

@felixfang any update on this, when this can be released?

[reply2srij]

Can we get an update on this please?

[glc-froussel]

Can we get an update on this please?

It has been released on November 22 ;)

[SeijiSuenaga]

Is it just me, or are stack-level tags not always applied to log group resources in the stack? I'm seeing inconsistent results where log groups don't always (but sometimes do) have all the tags that are on the stack.

[glc-froussel]

Is it just me, or are stack-level tags not always applied to log group resources in the stack? I'm seeing inconsistent results where log groups don't always (but sometimes do) have all the tags that are on the stack.

I had the same behaviour and the cause was that I had to explicitly create the log group resource in the CF template instead of having the related resource create it (aka, the log group must be part of your stack resources).

Maybe you are facing the same issue ?

[mgmarino]

Is it just me, or are stack-level tags not always applied to log group resources in the stack? I'm seeing inconsistent results where log groups don't always (but sometimes do) have all the tags that are on the stack.

CF will only propagate changes. In other words, if you have stack-level tags and they have not changed since this feature was introduced, they will not get propagated to the log groups. For already existing stacks, this was an issue for us since we have some tags that do not regularly change on deployments. (Some, like the Version, do, and these were getting propagated as expected.) To force the tags to get propagated, we had to do some manual deployments setting the tags to a temporary value (note, just omitting them will not "delete" them), and then a subsequent deployment with the correct tag values.

[SeijiSuenaga]

Is it just me, or are stack-level tags not always applied to log group resources in the stack? I'm seeing inconsistent results where log groups don't always (but sometimes do) have all the tags that are on the stack.

CF will only propagate changes. In other words, if you have stack-level tags and they have not changed since this feature was introduced, they will not get propagated to the log groups. For already existing stacks, this was an issue for us since we have some tags that do not regularly change on deployments. (Some, like the Version, do, and these were getting propagated as expected.) To force the tags to get propagated, we had to do some manual deployments setting the tags to a temporary value (note, just omitting them will not "delete" them), and then a subsequent deployment with the correct tag values.

Thank you, that's exactly what's happening in my case, so I'll have to do some manual shenanigans too unfortunately.