search

aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

Migrate logs repo from travisCI to GitHub actions #54

Closed johnttompkins closed 1 year ago

johnttompkins commented 3 years ago

Issue #, if available:

Description of changes: Migrates the travis continuous integration jobs to GitHub actions. Similar to: https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/pull/108.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

johnttompkins commented 3 years ago

hundreds of aws-cloudformation-resource-providers repos to migrate and we've already gone through a lot of CI PR churn for them (all of @miparnisari's PRs to make sure Maven builds run instead of just pre-commit formatting, switching between CodeBuild, Travis, Github Actions, etc), so let's migrate all of them together

I'd prefer if we took the chance to improve these before starting to manually migrate hundreds of repos one-by-one. These should also be running cfn validate and cfn submit --dry-run at the very least and arguably cfn test and git-secrets as well

Doing a quick spot check it appears only 12/38 public resource provider repositories have a travis build job. All for automation of this process but we would probably have to schedule some dedicated work to do a big overhaul.

The process of team commits to repo -> travisCI build doesn't work -> looks to documentation as to why -> sees example github action -> upgrades doesn't seem too bad for now.

PatMyron commented 3 years ago

Doing a quick spot check it appears only 12/38 public resource provider repositories have a travis build job

Only a dozen repos even meeting one best practice from 2019 feels like even more reason to centralize the process longterm

Most don't even successfully compile because of issues like V2 upgrade or not having updated the external Maven pom.xml at all due to only working internally with Brazil Config:

$ grep -L 'software.amazon.awssdk' */*/pom.xml # SDK missing from Maven dependencies
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificate/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthority/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-acmpca/aws-acmpca-certificateauthorityactivation/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-cloudformation/aws-cloudformation-moduleversion/pom.xml
aws-cloudformation-resource-providers-ec2-cagw/aws-ec2-carriergateway/pom.xml
aws-cloudformation-resource-providers-ec2-prefix-list/aws-ec2-prefixlist/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-accelerator/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-endpointgroup/pom.xml
aws-cloudformation-resource-providers-globalaccelerator/aws-globalaccelerator-listener/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-authorizer/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-certificate/pom.xml
aws-cloudformation-resource-providers-iot/aws-iot-provisioningtemplate/pom.xml
aws-cloudformation-resource-providers-rds-proxy/aws-rds-dbproxy/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-rds-proxy/aws-rds-dbproxytargetgroup/pom.xml # just a different Maven namespace
aws-cloudformation-resource-providers-timestream/aws-timestream-database/pom.xml
aws-cloudformation-resource-providers-timestream/aws-timestream-table/pom.xml

$ grep -A 1 'aws-cloudformation-rpdk-java-plugin' */*/pom.xml | grep -B 1 '>1\.' # deprecated aws-cloudformation-rpdk-java-plugin v1
...
markkuhn commented 2 years ago

This PR has been open for more than a year. Can we close it?