Closed stiak closed 3 years ago
I'd prefer keeping attribute names identical - its a source of consistent frustration when they change between representations, given how much documentation is auto-generated/etc. So, PolicyName would be preferred.
And thank you for taking this on, we literally just ran into this today and had to rethink a ton of stuff now that we can't do 'native' cfn for our project.
+1 on adamcrosby's comment - thanks for taking this up. I left some comments.
Also, when you have a change, can you paste your integration test + contract test results? LMK if you have any questions about running these, you can also check out the walk through here: https://docs.aws.amazon.com/cloudformation-cli/latest/userguide/resource-type-walkthrough.html#resource-type-walkthrough-test
contract-test-output.txt I had a few runs but there always seemed to be some that timed out. It's also really painfully slow...
Ah, found the --warm-containers EAGER
option. Much better. Requests take 250ms instead of 13.5 seconds.
Updated output from contract tests (15 passed, 1 skipped).
I think I've addressed all the feedback now, let me know if there's anything else I should follow up on.
looks good, thanks for contributing @stiak
Issue #, if available: https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/249
Description of changes: This adds a
AWS::Logs::ResourcePolicy
type.A few questions that I need help to answer:
Name
attribute, though the API usesPolicyName
. Any preferences?~ It'sPolicyName
to matchDescribeResourcePoliciesResponse
. Test remains as commented out code.~ I used the approach from metric filter.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.