aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

add required field in JSON schema, change exception thrown for one failure case #58

Closed sfbaker7 closed 1 year ago

sfbaker7 commented 3 years ago

Issue #, if available:

Description of changes: Adds a required field that is consistent with PutQueryDefinition API. This requires queryDef name, query string, and makes log group optional

Changes exception thrown when trying to update a non-existant resource from invalid request to not found as per CFN's contract testing requirements

Testing

Unit Tests

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  23.964 s
[INFO] Finished at: 2021-03-22T10:59:20-07:00
[INFO] ------------------------------------------------------------------------

Contract tests:

===================================================================== 13 passed, 3 skipped, 8 warnings in 895.06s (0:14:55) ======================================================================

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

markkuhn commented 1 year ago

This PR has been open for more than a year. Can we close it?