search

aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

Fix warnings from cfn validate #61

Closed AaronLi closed 1 year ago

AaronLi commented 3 years ago

Issue #, if available: None Description of changes: When running cfn validate on the most recent version of cloudformation-cli, I would get the warning: Explicitly specify value for taggable. This change fixes that issue.

Specifying "taggable": false means the update handler for the resource won't be called when updating stack tags. Specifying "insertionOrder": false means a change in the order of an array won't count as drift during drift detection tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

markkuhn commented 1 year ago

This PR has been open for more than a year. Can we close it?