search

aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

Fixes Contract Test Errors for MetricFilter and Destination. #62

Closed AaronLi closed 1 year ago

AaronLi commented 3 years ago

Issue #, if available: None Description of changes: Fixes Contract Test Errors for MetricFilter and Destination.

Destination changes are to fix the AssertionError: The deletion handler's response object MUST NOT contain a model error

MetricFilter changes are to fix the same error as above as well as AssertionError: All properties specified in the request MUST be present in the model returned, and they MUST match exactly, with the exception of properties defined as writeOnlyProperties in the resource schema

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

markkuhn commented 2 years ago

This PR has been open for more than a year. Can we close it?

shri-tambe commented 1 year ago

Let's fix the conflicts and rebase against latest changes.