search

aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs
https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html
Apache License 2.0
33 stars 35 forks source link

Fail and return NotFound error code on Delete #8

Closed aygold92 closed 4 years ago

aygold92 commented 5 years ago

The Handler Contract states that we should fail and return NotFound on Delete, and then the Client should ignore this error. This is to provide consistency across different implementations

miparnisari commented 4 years ago

@aygold92 is this about the LogGroup type? Because if so, this is already here:

https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-logs/blob/3dcd55b8e95cc76ccf9f2fb64318f0b2bbbd5547/aws-logs-loggroup/src/main/java/software/amazon/logs/loggroup/DeleteHandler.java#L25

aygold92 commented 4 years ago

not sure the history of this but it appears to be resolved