Adding Logs MetricFilter Dimensions and Unit Support

aws-cloudformation / aws-cloudformation-resource-providers-logs

The CloudFormation Resource Provider Package For Amazon CloudWatch Logs

https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/WhatIsCloudWatchLogs.html

Apache License 2.0

33 stars 35 forks source link

Adding Logs MetricFilter Dimensions and Unit Support #84

Closed waifa closed 2 years ago

waifa commented 2 years ago

Issue #, if available: AWS::Logs::MetricFilter does not accept dimensions #64

Description of changes: This PR is to implement a feature request for dimensions and unit support in Metric Filter via CFN. See https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-logs/issues/64 for more info.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

waifa commented 2 years ago

this comment verifies that this PR successfully passes all unit tests and builds(via "mvn package")

VRevol commented 2 years ago

Does it mean it is from now on available to use in CFN ? Documentation is still not referencing it ;) https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-logs-metricfilter-metrictransformation.html

I may give it a try ;)

waifa commented 2 years ago

Hi VRevol, the feature isn't available yet. Deploying to all regions shortly. Documentation will be updated as well once the feature is available. I will update this PR and the git issue once completed(#64)