aws-cloudformation / aws-cloudformation-resource-providers-rds

The CloudFormation Resource Provider Package For Amazon Relational Database Service
https://aws.amazon.com/rds/
Apache License 2.0
27 stars 43 forks source link

[DBInstance] Modify after create - storage parameters fixes #425

Closed khebul closed 1 year ago

khebul commented 1 year ago

This PR modifies logic for ModifyAfterCreate when storage parameters were updated. Previously, modify request would run for any engine if storage parameters were modified. Now modify only runs for SQL server.

In addition, previously if storage type was set on DBInstance, modify after create workflow would not run. Now it correctly triggers modify after create.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.