aws-cloudformation / aws-cloudformation-resource-providers-rds

The CloudFormation Resource Provider Package For Amazon Relational Database Service
https://aws.amazon.com/rds/
Apache License 2.0
26 stars 42 forks source link

[CustomDbEngineVersion] Add new parameters in CEV #478

Closed 0ooopsFibby closed 3 months ago

0ooopsFibby commented 10 months ago

Issue #, if available: N / A

Description of changes:

Latest AWS RDS SDK has added three optional parameters for CEV model and originally required field is now no longer compulsory. This PR is to add the additional parameters to CFN accordingly.

Tests:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

0ooopsFibby commented 10 months ago

Can you kindly confirm if all possible exceptions have been taken care of?

if the SourceCustomDBEngineVersionIdentifier or ImageId is not found or in an inappropriate state for the operation, what specific exceptions will be thrown?

Moreover, It will need to be associated with a recognized error from CloudFormation by adding it to the CreateHandler error role set, otherwise It will lead to an internal failure on the customer's end.

Yes I checked exceptions that could be thrown from the latest change, all have been covered by existing CreateHandler exceptions:

0ooopsFibby commented 10 months ago
  • "s3:GetObject"

Thanks for the reminder! I do need to add additional permissions.

zrfr commented 3 months ago

Superseded by https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/pull/515