Closed 0ooopsFibby closed 3 months ago
Can you kindly confirm if all possible exceptions have been taken care of?
if the
SourceCustomDBEngineVersionIdentifier
orImageId
is not found or in an inappropriate state for the operation, what specific exceptions will be thrown?Moreover, It will need to be associated with a recognized error from CloudFormation by adding it to the CreateHandler error role set, otherwise It will lead to an internal failure on the customer's end.
Yes I checked exceptions that could be thrown from the latest change, all have been covered by existing CreateHandler exceptions:
- "s3:GetObject"
Thanks for the reminder! I do need to add additional permissions.
Issue #, if available: N / A
Description of changes:
Latest AWS RDS SDK has added three optional parameters for CEV model and originally required field is now no longer compulsory. This PR is to add the additional parameters to CFN accordingly.
Tests:
test_read_input_output_negative_match from contract test doesn't apply for the API, this is because some parameters are not supposed to be used together (e.g. S3 bucket and source CEV). This particular test will fail with below if enabled.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.