aws-cloudformation / aws-cloudformation-resource-providers-rds

The CloudFormation Resource Provider Package For Amazon Relational Database Service
https://aws.amazon.com/rds/
Apache License 2.0
26 stars 42 forks source link

[DBInstance] Ignore terminal domain on delete #479

Closed dbbh closed 9 months ago

dbbh commented 10 months ago

Issue #, if available:

Description of changes: This change moves the terminal state check in the DBInstance handler for RDS resources into a separate helper method. Creates and modifies continue to assert terminal status on all resources while delete requests are now only checking for RDS resources. This means terminal domains will no longer impact delete workflows.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.