aws-cloudformation / aws-cloudformation-resource-providers-rds

The CloudFormation Resource Provider Package For Amazon Relational Database Service
https://aws.amazon.com/rds/
Apache License 2.0
26 stars 42 forks source link

fix(DBInstance): allow deleting cluster instances through CCAPI #550

Closed zrfr closed 3 weeks ago

zrfr commented 1 month ago

This change fixes an issue preventing cluster instances from being deleted using Cloud Control API.

Final snapshots are not possible for read replicas and cluster instances. The issue was that the handler was determining this based on instance details provided in the request. CCAPI does not provide these details. The fix is to retrieve the instance details from RDS instead of relying on the request.

Test: unit tests and contract tests.

Issue: aws-cloudformation/cloudformation-coverage-roadmap#2013

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.