Fix type metrics - Githubissues

aws-cloudformation / aws-cloudformation-resource-providers-stepfunctions

The CloudFormation Resource Provider Package For AWS Step Functions

https://aws.amazon.com/step-functions/

Apache License 2.0

6 stars 4 forks source link

Fix type metrics #10

Closed jormello closed 3 years ago

jormello commented 3 years ago

Issue #, if available:

Description of changes: State Machine type defaults to Standard if not provided. Currently metrics are only collected if the type is not null. After this change, null type will be logged as a Standard state machine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

shivlaks commented 3 years ago

nit:

i think we should standardize on the headers for commit messages similar to how we do it with the data-science-sdk or with the cdk (which follows conventional commits
remove the header fields if they don't point to an issue
should also add a line break between commit message and the By submitting this pull request... bit