search

aws-cloudformation / aws-cloudformation-samples

Apache License 2.0
136 stars 53 forks source link

Added instance type/family validation for AWS::EC2::Host. #66

Closed mrinaudo-aws closed 1 year ago

mrinaudo-aws commented 1 year ago

Issue #, if available:

Description of changes: Added instance type/family validation for AWS::EC2::Host.

Unit tests excerpts

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.awssamples.ec2instancetypes.hook.PreUpdateHookHandlerTest
[INFO] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.537 s - in com.awssamples.ec2instancetypes.hook.PreUpdateHookHandlerTest
[INFO] Running com.awssamples.ec2instancetypes.hook.PreCreateHookHandlerTest
[INFO] Tests run: 36, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 s - in com.awssamples.ec2instancetypes.hook.PreCreateHookHandlerTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 72, Failures: 0, Errors: 0, Skipped: 0
[...]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  25.052 s
[INFO] Finished at: 2022-12-09T14:06:42-05:00
[INFO] ------------------------------------------------------------------------

Contract tests excerpts

Input 1

[...]
collected 24 items / 17 deselected / 7 selected                                                                                                                                                       

[...]/T/hook/handler_pre_create.py::contract_pre_create_success PASSED                                            [ 14%]
[...]/T/hook/handler_pre_create.py::contract_pre_create_failed PASSED                                             [ 28%]
[...]/T/hook/handler_pre_create.py::contract_pre_create_failed_unsupported_target SKIPPED (No wildcard hook t...) [ 42%]
[...]/T/hook/handler_pre_update.py::contract_pre_update_success PASSED                                            [ 57%]
[...]/T/hook/handler_pre_update.py::contract_pre_update_failed PASSED                                             [ 71%]
[...]/T/hook/handler_pre_update.py::contract_pre_update_failed_unsupported_target SKIPPED (No wildcard hook t...) [ 85%]
[...]/T/resource/handler_misc.py::contract_check_asserts_work PASSED                                              [100%]
[...]
[...] 5 passed, 2 skipped, 17 deselected in 856.49s (0:14:16) [...]
[...]

Input 2

[...]/T/hook/handler_pre_create.py::contract_pre_create_success PASSED                                            [ 14%]
[...]/T/hook/handler_pre_create.py::contract_pre_create_failed PASSED                                             [ 28%]
[...]/T/hook/handler_pre_create.py::contract_pre_create_failed_unsupported_target SKIPPED (No wildcard hook t...) [ 42%]
[...]/T/hook/handler_pre_update.py::contract_pre_update_success PASSED                                            [ 57%]
[...]/T/hook/handler_pre_update.py::contract_pre_update_failed PASSED                                             [ 71%]
[...]/T/hook/handler_pre_update.py::contract_pre_update_failed_unsupported_target SKIPPED (No wildcard hook t...) [ 85%]
[...]/T/resource/handler_misc.py::contract_check_asserts_work PASSED                                              [100%]
[...]
[...] 5 passed, 2 skipped, 17 deselected in 841.32s (0:14:01) [...]
[...]

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.