aws-cloudformation / aws-cloudformation-samples

Apache License 2.0
134 stars 55 forks source link

CloudFormation Hook for SQS incorrectly enforces TLS #72

Closed colonmelvin closed 1 year ago

colonmelvin commented 1 year ago

The example CfN hook for SQS enforces TLS by checking that aws:SecureTransport is True. Per the SQS developer guide, this should instead be a Deny statement and False. AWS CDK will also apply this Deny policy when enforcing TLS.

mrinaudo-aws commented 1 year ago

Hi @colonmelvin - thank you for your time in opening this issue! I have looked into it, and wrote an update to the code for this example hook. Once the code update is merged, it will close this issue. Thanks again!