aws-cloudformation / aws-cloudformation-templates

A collection of useful CloudFormation templates
Apache License 2.0
4.63k stars 4.23k forks source link

Possible typo in 'String' macro example #208

Closed rvalentini closed 4 months ago

rvalentini commented 5 years ago

https://github.com/awslabs/aws-cloudformation-templates/blob/master/aws/services/CloudFormation/MacrosExamples/StringFunctions/string.yaml

There seems to be a typo in the except block of the macro Lambda function:

In line 66 the parameter e is not defined.

macro_response["errorMessage"] = str(e)

So line 63 should probably be

except Exception as e:

instead of just

except Exception:
ericzbeard commented 4 months ago

Cleaning up stale issues in preparation for refreshing this repository. Please re-open if this still needs to be addressed.