aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.43k stars 591 forks source link

Better module support #1811

Open kddejong opened 3 years ago

kddejong commented 3 years ago

We've done a lot of work to not fail a template bases on Modules. However there are a lot of things we can do to build out better support.

Reading the registry to determine the parameters and resource types. This allows us to validate naming conflicts, Ref/GetAtt relationships, if a module parameter is being used by a condition which means you can't ref/getatt that value, limits, etc.

Some of the big work to be done include:

PatMyron commented 3 years ago

We need to download the registry schema from a users account/region. This would include us needing to have credentials to get these files. Today cfn-lint doesn't require credentials and was completely designed to be offline validation. However with Registry Resource Types and Modules we need to think about starting being able to query an account inside cfn-lint.

Was thinking we could provide a script that could be run separately and allow the output to be passed in similar to https://github.com/aws-cloudformation/cfn-python-lint/pull/1732

miparnisari commented 3 years ago

However with Registry Resource Types and Modules we need to think about starting being able to query an account inside cfn-lint.

+1