search

aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.45k stars 592 forks source link

tox returns error locally #2755

Open whoDoneItAgain opened 1 year ago

whoDoneItAgain commented 1 year ago

CloudFormation Lint Version

0.77.6

What operating system are you using?

windows 11

Describe the bug

when i run tox locally (against the same commit for 0.77.6) i get 2 errors that dont show in the github tests.

Expected behavior

not to get errors locally on same commit as successful github test

Reproduction template

n/a

whoDoneItAgain commented 1 year ago 
PS C:\github-projects\github\cfn-lint> tox -e py310
py310: commands[0]> pip install -e .
Obtaining file:///C:/github-projects/github/cfn-lint
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Checking if build backend supports build_editable: started
  Checking if build backend supports build_editable: finished with status 'done'
  Getting requirements to build editable: started
  Getting requirements to build editable: finished with status 'done'
  Preparing editable metadata (pyproject.toml): started
Requirement already satisfied: typing-extensions<5,>=4.4 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (4.5.0)
Requirement already satisfied: pydantic~=1.8 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (1.10.7)
Requirement already satisfied: botocore<1.30.0,>=1.29.136 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from boto3==1.*,>=1.19.5->aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (1.29.136)   
Requirement already satisfied: jmespath<2.0.0,>=0.7.1 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from boto3==1.*,>=1.19.5->aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (1.0.1)
Requirement already satisfied: s3transfer<0.7.0,>=0.6.0 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from boto3==1.*,>=1.19.5->aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (0.6.1)        
Requirement already satisfied: attrs in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from jschema-to-python~=1.2.3->cfn-lint==0.77.6) (23.1.0)
Requirement already satisfied: jsonpickle in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from jschema-to-python~=1.2.3->cfn-lint==0.77.6) (3.0.1)
Requirement already satisfied: pbr in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from jschema-to-python~=1.2.3->cfn-lint==0.77.6) (5.11.1)
Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from jsonschema<5,>=3.0->cfn-lint==0.77.6) (0.19.3)
Requirement already satisfied: six in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from junit-xml~=1.9->cfn-lint==0.77.6) (1.16.0)
Requirement already satisfied: mpmath>=0.19 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from sympy>=1.0.0->cfn-lint==0.77.6) (1.3.0)
Requirement already satisfied: jsonpointer>=1.9 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from jsonpatch->cfn-lint==0.77.6) (2.3)
Requirement already satisfied: python-dateutil<3.0.0,>=2.1 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from botocore<1.30.0,>=1.29.136->boto3==1.*,>=1.19.5->aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (2.8.2)
Requirement already satisfied: urllib3<1.27,>=1.25.4 in c:\github-projects\github\cfn-lint\.tox\py310\lib\site-packages (from botocore<1.30.0,>=1.29.136->boto3==1.*,>=1.19.5->aws-sam-translator>=1.68.0->cfn-lint==0.77.6) (1.26.15)
Building wheels for collected packages: cfn-lint
  Building editable for cfn-lint (pyproject.toml): started
  Building editable for cfn-lint (pyproject.toml): finished with status 'done'
  Created wheel for cfn-lint: filename=cfn_lint-0.77.6-0.editable-py3-none-any.whl size=8536 sha256=9b3e61d2f43ec908e7f15114ac29c5c72a85f84e7d802ebd5fde2ca0488877a9
  Stored in directory: C:\Users\rbowm\AppData\Local\Temp\pip-ephem-wheel-cache-uaqh0uzi\wheels\ef\9d\7e\3daec89561cb2f70b73bff3937407dff92b08f7e99b7036e60
Successfully built cfn-lint
Installing collected packages: cfn-lint
  Attempting uninstall: cfn-lint
    Found existing installation: cfn-lint 0.77.6.dev1
    Uninstalling cfn-lint-0.77.6.dev1:
      Successfully uninstalled cfn-lint-0.77.6.dev1
Successfully installed cfn-lint-0.77.6
py310: commands[1]> coverage run -m unittest discover -s test
.F...F...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
======================================================================
FAIL: test_templates (integration.test_directives.TestDirectives)
Test ignoring certain rules
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\github-projects\github\cfn-lint\test\integration\__init__.py", line 36, in run_scenarios
    result = subprocess.check_output(
  File "C:\Users\rbowm\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "C:\Users\rbowm\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['cfn-lint', '--format', 'json', '--', 'test/fixtures/templates/good/core/directives.yaml']' returned non-zero exit status 8.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\github-projects\github\cfn-lint\test\integration\test_directives.py", line 132, in test_templates
    self.run_scenarios()
  File "C:\github-projects\github\cfn-lint\test\integration\__init__.py", line 61, in run_scenarios
    self.assertEqual(
AssertionError: 8 != 0 : Expected 0 exit code, got 8 on test/fixtures/templates/good/core/directives.yaml

======================================================================
FAIL: test_templates (integration.test_good_templates.TestQuickStartTemplates)
Test Successful JSON Parsing
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\github-projects\github\cfn-lint\test\integration\__init__.py", line 36, in run_scenarios
    result = subprocess.check_output(
  File "C:\Users\rbowm\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 421, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "C:\Users\rbowm\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['cfn-lint', '--format', 'json', '--', 'test/fixtures/templates/good/transform.yaml']' returned non-zero exit status 8.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\github-projects\github\cfn-lint\test\integration\test_good_templates.py", line 181, in test_templates
    self.run_scenarios()
  File "C:\github-projects\github\cfn-lint\test\integration\__init__.py", line 61, in run_scenarios
    self.assertEqual(
AssertionError: 8 != 0 : Expected 0 exit code, got 8 on test/fixtures/templates/good/transform.yaml

----------------------------------------------------------------------
Ran 597 tests in 73.725s

FAILED (failures=2)
py310: exit 1 (77.11 seconds) C:\github-projects\github\cfn-lint> coverage run -m unittest discover -s test pid=29584
  py310: FAIL code 1 (84.45=setup[0.08]+cmd[7.26,77.11] seconds)
  evaluation failed :( (84.69 seconds)
PS C:\github-projects\github\cfn-lint>
kddejong commented 3 months ago

Haven't been able to replicate this issue with python 3.10 and windows 11. If you still have issues can you share the output of cfn-lint -- test/fixtures/templates/good/transform.yaml so I know what rule it was that was tossing errors. We do run the tests on windows instances so a bummer we are running into this.