aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.43k stars 591 forks source link

Update resolution to properly config errors #3273

Closed kddejong closed 4 months ago

kddejong commented 4 months ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 92.62%. Comparing base (cd4912e) to head (307f360).

Files Patch % Lines
src/cfnlint/jsonschema/_resolvers_cfn.py 20.00% 2 Missing and 2 partials :warning:
src/cfnlint/jsonschema/validators.py 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3273 +/- ## ========================================== - Coverage 92.77% 92.62% -0.15% ========================================== Files 309 309 Lines 10654 10661 +7 Branches 2247 2251 +4 ========================================== - Hits 9884 9875 -9 - Misses 432 443 +11 - Partials 338 343 +5 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3273/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3273/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.