aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.43k stars 591 forks source link

Improve testing on read only rule #3275

Closed kddejong closed 4 months ago

kddejong commented 4 months ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.81%. Comparing base (099df82) to head (497cb8b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3275 +/- ## ========================================== - Coverage 92.87% 92.81% -0.07% ========================================== Files 320 320 Lines 10743 10743 Branches 2254 2254 ========================================== - Hits 9978 9971 -7 - Misses 427 431 +4 - Partials 338 341 +3 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.