aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.41k stars 577 forks source link

V1 Cleanup based on testing of templates repo #3303

Closed kddejong closed 1 month ago

kddejong commented 1 month ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.25%. Comparing base (186a63d) to head (fdaf279).

Files Patch % Lines
src/cfnlint/conditions/conditions.py 93.33% 1 Missing and 1 partial :warning:
src/cfnlint/context/_conditions.py 95.45% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3303 +/- ## ========================================== - Coverage 93.29% 93.25% -0.04% ========================================== Files 319 320 +1 Lines 10766 10855 +89 Branches 2241 2267 +26 ========================================== + Hits 10044 10123 +79 - Misses 400 405 +5 - Partials 322 327 +5 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3303/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.