aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.43k stars 590 forks source link

Update logic on GetAtts for resources that have all attrs #3344

Closed kddejong closed 3 months ago

kddejong commented 3 months ago

Issue #, if available: fix #3320

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.28%. Comparing base (df4eb52) to head (c4c7f44).

:exclamation: Current head c4c7f44 differs from pull request most recent head b369f69

Please upload reports for the commit b369f69 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3344 +/- ## ========================================== - Coverage 93.29% 93.28% -0.01% ========================================== Files 322 322 Lines 10924 10923 -1 Branches 2278 2278 ========================================== - Hits 10192 10190 -2 Misses 406 406 - Partials 326 327 +1 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3344/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.