aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.4k stars 576 forks source link

update logic in rule E3686 #3367

Closed kddejong closed 1 week ago

kddejong commented 1 week ago

Issue #, if available: fix #3366

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.21%. Comparing base (4244af2) to head (b458d06).

Files Patch % Lines
...ules/resources/rds/DbClusterServerlessExclusive.py 66.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3367 +/- ## ========================================== - Coverage 93.24% 93.21% -0.03% ========================================== Files 323 323 Lines 10965 10969 +4 Branches 2285 2287 +2 ========================================== + Hits 10224 10225 +1 - Misses 415 416 +1 - Partials 326 328 +2 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3367/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3367/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.