aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.4k stars 576 forks source link

Relax E3041 to support DNS root records #3377

Closed jakob-keller closed 1 week ago

jakob-keller commented 1 week ago

Issue #, if available: closes #3376

Description of changes: Relax E3041 to support AWS::Route53::RecordSet resources that specify DNS root records.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.23%. Comparing base (7008855) to head (3f4b5fe).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3377 +/- ## ========================================== - Coverage 93.24% 93.23% -0.02% ========================================== Files 323 323 Lines 10993 10991 -2 Branches 2295 2294 -1 ========================================== - Hits 10250 10247 -3 Misses 416 416 - Partials 327 328 +1 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3377/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3377/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.