aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.4k stars 576 forks source link

Update resolution validation to only return an error if there are no valid values #3390

Closed kddejong closed 1 week ago

kddejong commented 1 week ago

Issue #, if available: fix #3380

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.21%. Comparing base (3d9be79) to head (1dd51b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3390 +/- ## ========================================== + Coverage 93.13% 93.21% +0.07% ========================================== Files 323 323 Lines 10990 11005 +15 Branches 2294 2299 +5 ========================================== + Hits 10236 10258 +22 + Misses 420 416 -4 + Partials 334 331 -3 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3390/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3390/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.