aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.4k stars 577 forks source link

Greatly simplify findinmap resolution #3406

Closed kddejong closed 1 week ago

kddejong commented 1 week ago

Issue #, if available:

Description of changes:

Too many scenarios and thoughts around how to properly show errors when functions are involved inside a findinmap. We can revisit this and expand it as needed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.33%. Comparing base (db0097e) to head (160b30e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3406 +/- ## ========================================== + Coverage 93.25% 93.33% +0.08% ========================================== Files 323 323 Lines 11020 11004 -16 Branches 2302 2297 -5 ========================================== - Hits 10277 10271 -6 + Misses 414 408 -6 + Partials 329 325 -4 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3406/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.