aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.4k stars 576 forks source link

Add two new rules to validate fargate tasks #3464

Open kddejong opened 3 days ago

kddejong commented 3 days ago

Issue #, if available:

3453

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.32%. Comparing base (8a40ff1) to head (731f5cd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3464 +/- ## ========================================== + Coverage 93.30% 93.32% +0.01% ========================================== Files 324 326 +2 Lines 11058 11096 +38 Branches 2318 2320 +2 ========================================== + Hits 10318 10355 +37 Misses 415 415 - Partials 325 326 +1 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3464/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3464/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kddejong commented 3 days ago

While the schema specifies the values as strings they are integers. These rules will accept both and work accordingly. Tried to favor the string method as much as possible.