search

aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.43k stars 585 forks source link

E3693 - PerformanceInsightsEnabled not recognised as valid attribute for DB Cluster #3693

Closed armanjal closed 2 days ago

armanjal commented 2 days ago

CloudFormation Lint Version

1.14.0 and 1.12.4

What operating system are you using?

Mac

Describe the bug

E3693 Additional properties are not allowed 'PerformanceInsightsEnabled' when creating Aurora cluster

Expected behavior

Cloudformation allows PerformanceInsightsEnabled as a property and does actually make the expected changes when deployed. Cfn-lint should allow this property to be added in a DB cluster. See docs here.

Reproduction template

Dbcluster with PerformanceInsightsEnabled in the block

kddejong commented 2 days ago

This rule is related to Valid for Cluster Type: Multi-AZ DB clusters only in the docs. This is a capability of aurora clusters too so the docs may be off. Going to test it out and double validate.

More docs If you use Performance Insights with Aurora global databases, turn on Performance Insights individually for the DB instances in each AWS Region. For details, see [Monitoring an Amazon Aurora global database with Amazon RDS Performance Insights](https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/aurora-global-database-monitoring.html#aurora-global-database-pi).

kddejong commented 2 days ago

After testing it appears that this should be a Warning for PerformanceInsightsEnabled as the cluster will still be successful but the value will not be set or work as intended.

kddejong commented 2 days ago

One last thing. Aurora Serverless v1 doesn't support this property. This is a totally configurable option for Aurora Serverless v2.

Going to move this to a new Warning rule that will only alert when using Auro Serverless v1

armanjal commented 1 day ago

Many thanks for the fast turnaround! I should have mentioned that I'm using a Multi-AZ, Aurora Serverless V2 instances cluster