aws-cloudformation / cfn-lint

CloudFormation Linter
MIT No Attribution
2.46k stars 596 forks source link

add logic to handle substitutions #3768

Closed kddejong closed 1 month ago

kddejong commented 1 month ago

Issue #, if available: fix #3724 Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.76%. Comparing base (8e463fb) to head (b786784). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../resources/stepfunctions/StateMachineDefinition.py 93.10% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3768 +/- ## ========================================== - Coverage 93.77% 93.76% -0.01% ========================================== Files 362 362 Lines 12356 12371 +15 Branches 2521 2527 +6 ========================================== + Hits 11587 11600 +13 Misses 429 429 - Partials 340 342 +2 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3768/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cfn-lint/pull/3768/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `93.72% <93.10%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.