Fix importpath backward incompatible change

aws-cloudformation / cloudformation-cli-go-plugin

The CloudFormation Provider Development Toolkit Go Plugin allows you to autogenerate Go code based on an input schema.

52 stars 31 forks source link

Closed omkhegde closed 4 years ago

omkhegde commented 4 years ago

Issue #, if available: #177

Description of changes:

importpath was changed to import_path in a recent change to receive argument from the cfn cli. This change breaks existing resources. Reverting property name to import_path

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

x6j8x commented 4 years ago

I just changed all my resources to the new "import_path" property and now I'm supposed to change it back? sigh

jaymccon commented 4 years ago

how about leaving import_path as is, and just do something like Path(project.settings.get("import_path", project.settings["importpath"]))