Set GOARCH=amd64 in build

aws-cloudformation / cloudformation-cli-go-plugin

The CloudFormation Provider Development Toolkit Go Plugin allows you to autogenerate Go code based on an input schema.

52 stars 31 forks source link

Set GOARCH=amd64 in build #194

Closed rclark closed 1 year ago

rclark commented 3 years ago

https://github.com/aws-cloudformation/cloudformation-cli-go-plugin/blob/d23e052b5de23d9026d9e39c5f488279ea7900a4/python/rpdk/go/templates/makebuild#L7

On arm64 systems (e.g. new M1 Macs) this results in a binary built for the wrong architecture. Adding GOARCH=amd64 would make sure that the binaries are appropriate for Lambda runtimes.

mlafeldt commented 3 years ago

Our current workaround is to pass GOARCH to makebuild:

build:
    env GOARCH=amd64 TAGS=logging make -f makebuild

Of course, a real fix would be nice!

mmaeng commented 1 year ago

Implemented in PR #209