aws-cloudformation / cloudformation-cli-go-plugin

The CloudFormation Provider Development Toolkit Go Plugin allows you to autogenerate Go code based on an input schema.
52 stars 31 forks source link

go1.x to provided.al2 migration #230

Closed msummers-nr closed 10 months ago

msummers-nr commented 10 months ago

Issue #229 :

Description of changes: Changes required to migrate from go1.x to provided.al2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kddejong commented 10 months ago

Also worth noting provided.al2023 just came out too. https://docs.aws.amazon.com/lambda/latest/dg/runtimes-custom.html

https://aws.amazon.com/blogs/compute/introducing-the-amazon-linux-2023-runtime-for-aws-lambda/

msummers-nr commented 10 months ago

@kddejong I followed the Migration guide published in July, it uses provided.al2.

I couldn't figure-out how to build this with options, or how cfn would use that capability- hard coding these values is awfully brittle.

kddejong commented 10 months ago

If we can rebase to master the CI/CD issues should resolve itself.

msummers-nr commented 10 months ago

@kddejong rebase done

mircealam commented 10 months ago

looks like there is an issue with the end of file for one of the files

fix end of files.........................................................Failed

Fixing examples/github-repo/makebuild

msummers-nr commented 10 months ago

2 of the generated example files were missing from .gitignore, I've deleted them from git and updated .gitignore- that was causing the EOF problem.

mircealam commented 10 months ago

2 of the generated example files were missing from .gitignore, I've deleted them from git and updated .gitignore- that was causing the EOF problem.

Still failing CI:

https://github.com/aws-cloudformation/cloudformation-cli-go-plugin/actions/runs/6903650678/job/18792040714?pr=230

msummers-nr commented 10 months ago

That's interesting- cfn generate generates a README.md that trips fix end of files

mircealam commented 10 months ago

@msummers-nr thank you for your contribution.