Closed msummers-nr closed 10 months ago
Also worth noting provided.al2023 just came out too. https://docs.aws.amazon.com/lambda/latest/dg/runtimes-custom.html
https://aws.amazon.com/blogs/compute/introducing-the-amazon-linux-2023-runtime-for-aws-lambda/
@kddejong I followed the Migration guide published in July, it uses provided.al2
.
I couldn't figure-out how to build this with options, or how cfn
would use that capability- hard coding these values is awfully brittle.
If we can rebase to master the CI/CD issues should resolve itself.
@kddejong rebase done
looks like there is an issue with the end of file for one of the files
fix end of files.........................................................Failed
Fixing examples/github-repo/makebuild
2 of the generated example files were missing from .gitignore, I've deleted them from git and updated .gitignore- that was causing the EOF problem.
2 of the generated example files were missing from .gitignore, I've deleted them from git and updated .gitignore- that was causing the EOF problem.
Still failing CI:
That's interesting- cfn generate
generates a README.md
that trips fix end of files
@msummers-nr thank you for your contribution.
Issue #229 :
Description of changes: Changes required to migrate from go1.x to provided.al2
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.