search

aws-cloudformation / cloudformation-cli-java-plugin

The CloudFormation Provider Development Toolkit Java Plugin allows you to autogenerate java code based on an input schema.
Apache License 2.0
30 stars 47 forks source link

Fix method name collisions for getProperties() #434

Closed mrinaudo-aws closed 10 months ago

mrinaudo-aws commented 10 months ago

Issue #, if available:

Description of changes: Fix method name collisions for getProperties() when a target resource type has a Properties property defined, and Lombok-generated getters (and setters) are named getProperties() (and setProperties(), respectively), whereas the former collides with getProperties() already defined for ResourceHookTarget.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mrinaudo-aws commented 10 months ago

@akshayrane @brianlaoaws @reza-aws @rpdutt I'm converting this PR to a draft to explore the possibility to have a resolution dedicated to hooks, as this plugin is also used for resource types whose generated classes are also processed by the same logic that this PR updates.