aws-cloudformation / cloudformation-cli-python-plugin

The CloudFormation Provider Development Toolkit Python Plugin allows you to autogenerate Python code based on an input schema.
Apache License 2.0
108 stars 47 forks source link

Removed account ID from metric namespace #108

Closed cortez7 closed 4 years ago

cortez7 commented 4 years ago

Main PR for Java plugin: https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/293

The removed account ID is the customer account ID instead of the provider account ID. This means that for public types, a new metric namespace would be created each time we need to emit metrics. The main issue with this is that the internal and logging failure alarms will not work properly and service teams may not be notified of issues.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.