aws-cloudformation / cloudformation-cli-python-plugin

The CloudFormation Provider Development Toolkit Python Plugin allows you to autogenerate Python code based on an input schema.
Apache License 2.0
108 stars 47 forks source link

Make certain request fields optional to unblock contract testing. #120

Closed johnttompkins closed 4 years ago

johnttompkins commented 4 years ago

Issue #, if available: #112 #109

Description of changes: This change makes some request fields optional/removes certain fields so that contract testing via cfn test can complete successfully without library errors. Below are a list of the changes to the request:

The first commit contains the bulk of these changes. The second commit just changes MetricPublisher->MetricsPublisher so the spelling is in line with the java plugin and the proxy :)

Testing done:

Created a dummy resource with the latest cloudformation-cli and ran cfn-test on a resource with this new support lib. Tests did not fail in the handler support lib like previously.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

johnttompkins commented 4 years ago

Testing this in a stack I got some unexpected errors. Going to investigate further before attempting to merge.