aws-cloudformation / cloudformation-cli-typescript-plugin

The CloudFormation Provider Development Toolkit Node.js Plugin allows you to autogenerate TypeScript code based on an input schema.
Apache License 2.0
45 stars 15 forks source link

Stop logging event data #117

Closed rajdivya closed 1 year ago

rajdivya commented 1 year ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1611daa) 98.56% compared to head (12b7ecb) 98.55%.

:exclamation: Current head 12b7ecb differs from pull request most recent head 208bdc6. Consider uploading reports for the commit 208bdc6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #117 +/- ## ========================================== - Coverage 98.56% 98.55% -0.01% ========================================== Files 14 14 Lines 1250 1249 -1 Branches 209 209 ========================================== - Hits 1232 1231 -1 Misses 17 17 Partials 1 1 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/117/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `98.55% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [src/resource.ts](https://app.codecov.io/gh/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#diff-c3JjL3Jlc291cmNlLnRz) | `97.25% <ø> (-0.02%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

agupta94 commented 11 months ago

Hi @rajdivya , what was the reasoning behind this? I use EVENT DATA log for various debugging reasons. It was helpful to get insight into how the cloudformation event looked like.