search

aws-cloudformation / cloudformation-cli-typescript-plugin

The CloudFormation Provider Development Toolkit Node.js Plugin allows you to autogenerate TypeScript code based on an input schema.
Apache License 2.0
45 stars 15 forks source link

bugfix: missing classtransformer upgrade and proper model types #129

Open HeatherFlux opened 3 months ago

HeatherFlux commented 3 months ago

Issue ARCH-1058

Description of changes:

Updating the template for the model to conform to the new type coming from class transformer as well as the codegen and package.json templates to match the new versions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

HeatherFlux commented 3 months ago

@kddejong Heyo, just packaged the python part and tested it and all good. Looks like the unit test issue is on the loggerproxy.

I can't replicate it on my end, but I'm using an M3

kddejong commented 3 months ago

I think #130 should fix it.

HeatherFlux commented 3 months ago

I think #130 should fix it.

oh hahaha I just did the same thing

kddejong commented 3 months ago

@HeatherFlux there is one more fix you will need for the macOS builds in that PR. Then I can close my PR

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.97%. Comparing base (115b7c0) to head (b3e34be). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #129 +/- ## ========================================== - Coverage 98.47% 97.97% -0.51% ========================================== Files 14 14 Lines 1249 1281 +32 Branches 213 244 +31 ========================================== + Hits 1230 1255 +25 - Misses 17 24 +7 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/129/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/aws-cloudformation/cloudformation-cli-typescript-plugin/pull/129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation) | `97.97% <100.00%> (-0.51%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aws-cloudformation#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HeatherFlux commented 3 months ago

Should be all good now

HeatherFlux commented 3 months ago

@kddejong any update on this getting merged?

HeatherFlux commented 3 months ago

@Jaredd94 @prerna-p @ammokhov @eduardomourar bump