search

aws-cloudformation / cloudformation-cli

The CloudFormation Provider Development Toolkit allows you to author your own resource providers and modules that can be used by CloudFormation.
Apache License 2.0
316 stars 157 forks source link

Updated the resource type walkthrough #980

Closed mrog closed 1 year ago

mrog commented 1 year ago

Issue #, if available: 979

Description of changes: Updating the resource type walkthrough so it works with current versions of CloudFormation and dependencies.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mmaeng commented 1 year ago

@mrog If you could update your fork with the recent merges into the master branch? It looks like GitHub Actions got hung up for some reason on those 6 tests. Just want to kick start the workflow again.

mrog commented 1 year ago

@mmaeng I synced my fork. It should be okay to merge once the GitHub Actions are done. Thanks!

mmaeng commented 1 year ago

Looks like there are a few linting errors in the pre-commit. If you install pre-commit and run through the checks it should go through clean then. We are thinking we should be moving away from the pre-commit and just do it as part of the pipeline...

The install of pre-commit is defined in the Github actions file here (I would suggest a virtual env) https://github.com/aws-cloudformation/cloudformation-cli/blob/master/.github/workflows/pr-ci.yaml

Assuming you are running on a Mac but from the cloudformation-cli root directory - brew install autoconf automake libtool jq pip install pyjq pip install --upgrade 'attrs==19.2.0' wheel -r requirements.txt pip install . pre-commit run --all-files

Will have to run pre-commit a couple of times until it returns successful as it fixes linting issues. We have plans to rework pre-commit but it hasn't come to fruition yet.

Hope you don't mind but I pushed to your branch with the linting update.

mmaeng commented 1 year ago

Closes #979