aws-cloudformation / cloudformation-cli

The CloudFormation Provider Development Toolkit allows you to author your own resource providers and modules that can be used by CloudFormation.
Apache License 2.0
318 stars 161 forks source link

Improving logging for Ctv1 #996

Closed rajdnp closed 1 year ago

rajdnp commented 1 year ago

Issue #, if available:

Description of changes: Improving logging for Ctv1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing : Unit testing Pre-commit hooks are successful

Screenshots :

Error1 Error2 Error3 error4

Error5

rajdnp commented 1 year ago

The changes look good but are there no unit tests that we can add to validate the expected behavior?

Added more test https://github.com/aws-cloudformation/cloudformation-cli/pull/996/files#diff-56099aed7f1376770c545e5382edc0717d3a93376cb6371f3184f534c2f64b9e