search

aws-cloudformation / cloudformation-coverage-roadmap

The AWS CloudFormation Public Coverage Roadmap
https://aws.amazon.com/cloudformation/
Creative Commons Attribution Share Alike 4.0 International
1.11k stars 54 forks source link

AWS::EC2::LaunchTemplate LaunchTemplateData - PropagateTagsToVolumeOnCreation #1007

Open robertd opened 2 years ago

robertd commented 2 years ago

Name of the resource

AWS::EC2::LaunchTemplate

Resource name

No response

Description

Now that PropagateTagsToVolumeOnCreation is available on AWS::EC2::Instance resource (https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/133), it would be nice to expose this in AWS::EC2::LaunchTemplate LaunchTemplateData for the instances running in ASG. Tag propagation to underlying EBS volumes is a very important feature to us. About 90% of our launched solutions are EC2 instances being launched through ASG.

Other Details

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-propagatetagstovolumeoncreation

robertd commented 2 years ago

@WaelA Any chance you can expedite this one now that #133 is in place?

robertd commented 1 year ago

@WaelA @zjinmei Any updates on this? I assume LaunchConfiguration support in #1006 won't be considered given that LC is going away and LaunchTemplates are becoming a standard? Thanks in advance.

tivanov-qb commented 10 months ago

+1 on this one

AllanOricil commented 6 months ago

@WaelA

PropagateTagsToVolumeOnCreation is missing in @aws-sdk/client-ec2 RunInstancesCommand

image image
tivanov-qb commented 6 months ago

@zjinmei @WaelA are there any plans to fix this in near future ?

bhaum500 commented 1 month ago

Hello @tivanov-qb You can achieve the goal by using TagSpecification https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-tagspecification.html#cfn-ec2-launchtemplate-tagspecification-resourcetype

tivanov-qb commented 1 month ago

@bhaum500 was this recently fixed ? goal is tags to be propagated automatically to the ebs volumes

bhaum500 commented 1 month ago

Hello @tivanov-qb was looking for options like PropagateTagsToVolumeOnCreation to propagate tags automatically to the ebs volume, and got the above reference to add tags. And do you know any other better option to add tags at EBS level? Note: I am not from AWS Team 😄

tivanov-qb commented 1 month ago

@bhaum500 to work around the problem, i've developed lambda function that automatically tags our ebs volumes.