aws-cloudformation / cloudformation-coverage-roadmap

The AWS CloudFormation Public Coverage Roadmap
https://aws.amazon.com/cloudformation/
Creative Commons Attribution Share Alike 4.0 International
1.1k stars 53 forks source link

[AWS::ElasticLoadBalancingV2::Listener] - [Coverage] - Implement `Tags` feature #1460

Open r-heimann opened 1 year ago

r-heimann commented 1 year ago

Name of the resource

AWS::ElasticLoadBalancingV2::Listener

Description

It is possible to add Tags to Elastic Load Balancers listeners using

so it should also be possible to add tags to AWS::ElasticLoadBalancingV2::Listener using CloudFormation. This is currently not supported: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-listener.html

r-heimann commented 11 months ago

1d334575596e8d86f138dbeac3b7fe668a25111231408bfc280aeb3aac8146a4

r-heimann commented 9 months ago

Note: Once this feature has been implemented, Stack-Level Tags need to be checked if there are properly found by Drift Detection. Reference: https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/1346

CloudFormation identified an issue with recent release which caused the Drift Detection feature to incorrectly report some resources that do not support tags like

CloudWatch::Alarm
AWS::ElasticLoadBalancingV2::Listener
AWS::ElasticLoadBalancingV2::ListenerRule
AWS::Events::Rule

etc. as Drifted when stack level tags were applied due to incorrect tag comparison.
We are rolling back the deployment and the ETA for finishing the rollback is by 10/14/2022.
r-heimann commented 3 months ago

Since it's back in Coming Soon, i'm going to reuse my picture 256732177-1e43cde3-4926-4836-b176-49db7d74c28a

kika commented 1 month ago

Is implementing this feature also means that ELB, Listener and TargetGroup will be tagged with Cloudformation own tags ("aws:cloudformation:*) ? Because now for some reason they are not tagged after creation.

r-heimann commented 1 month ago

Is implementing this feature also means that ELB, Listener and TargetGroup will be tagged with Cloudformation own tags ("aws:cloudformation:*) ? Because now for some reason they are not tagged after creation.

Not sure if a GitHub issue and internal AWS Ticket already exists for that, but this issue only exists for the actual tagging support for AWS::ElasticLoadBalancingV2::Listener

rgoltz commented 1 month ago

@kika - There are already github issues for those topics - please, feel free to 👍+ share them:

Since each github issue is related to a dedicated resource, please comment and/or update the corresponding github issue for the Cloudformation own tags ("aws:cloudformation:*) topic.

r-heimann commented 3 weeks ago

b16