aws-cloudformation / cloudformation-coverage-roadmap

The AWS CloudFormation Public Coverage Roadmap
https://aws.amazon.com/cloudformation/
Creative Commons Attribution Share Alike 4.0 International
1.11k stars 54 forks source link

DMS ReplicationInstance propagated tags do not update #1845

Open nonspecialist opened 9 months ago

nonspecialist commented 9 months ago

Name of the resource

AWS::DMS::ReplicationInstance

Resource Name

No response

Issue Description

Thanks to https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/1252 DMS replication instances now get tags when they are created -- but changing tag keys and values in the stack do not propagate the updates to the replication instances.

Expected Behavior

CloudFormation stack tag updates should propagate to all resources that are tagged BY cloudformation in the first place.

Observed Behavior

Changing a tag key results in no change to the replication instance tags Deleting a tag key results in no change to the replication instance tags Adding a new tag key to an already-tagged instance results in no change to the replication instance tags

Test Cases

After the stack update, the tags have not changed: the new tag is not present, and the old tag is still there, even though the stack-level tags have changed

Adding a tag directly to the resource in the template and updating the stack DOES result in the in-template tag being applied, but command-line supplied tags are NOT applied after the initial creation.

Changing the tag directly on the resource in the template DOES result in the applied tag being changed, but again command-line supplied tags are NOT applied.

Other Details

AWSTemplateFormatVersion: 2010-09-09
Description: Replicate DMS Instance tagging failure

Resources:
  Instance:
    Type: AWS::DMS::ReplicationInstance
    Properties:
      ReplicationInstanceClass: dms.t2.micro