aws-cloudformation / cloudformation-coverage-roadmap

The AWS CloudFormation Public Coverage Roadmap
https://aws.amazon.com/cloudformation/
Creative Commons Attribution Share Alike 4.0 International
1.11k stars 56 forks source link

DMS Endpoint propagated tags are deleted instead of being updated #1846

Open nonspecialist opened 11 months ago

nonspecialist commented 11 months ago

Name of the resource

AWS::DMS::Endpoint

Resource Name

No response

Issue Description

When creating a DMS Endpoint via CloudFormation, with tags defined at the stack level, the resource is created correctly with the defined tags; but if the stack is updated to change the tags, the user-defined tags are REMOVED and new tags are not added.

This breaks reporting and tag compliance policies.

Expected Behavior

CloudFormation should maintain resource tags correctly.

Observed Behavior

CloudFormation deletes removed tags but does not add new tags

Test Cases

After the stack update, the Endpoint will only have the CloudFormation tags -- both the original user-defined tag and the new one are missing. The first tag should be missing, the second tag should not.

Subsequent updates to the resource don't add back ANY user-defined tags.

Setting tags explicitly in the template does work, but this is core functionality that is clearly broken.

Other Details

AWSTemplateFormatVersion: 2010-09-09
Description: Replicate DMS Endpoint tagging failure

Resources:
  Endpoint:
    Type: AWS::DMS::Endpoint
    Properties:
      EndpointType: source
      EngineName: oracle
      ServerName: florble.poons
      Port: 1234
      Username: meeply
      Password: plums
      DatabaseName: toad
      SslMode: none