aws-cloudformation / cloudformation-coverage-roadmap

The AWS CloudFormation Public Coverage Roadmap
https://aws.amazon.com/cloudformation/
Creative Commons Attribution Share Alike 4.0 International
1.1k stars 53 forks source link

AWS::RDS::DBInstance - [Coverage] - Missing parameters for `AutomaticBackupReplicationRegion` #2019

Open azatoth opened 2 months ago

azatoth commented 2 months ago

Name of the resource

AWS::RDS::DBInstance

Resource name

No response

Description

The recently added AutomaticBackupReplicationRegion property for AWS::RDS::DBInstance are missing a few parameters that are useful or required for proper function of the feature:

Other Details

Screenshot from the Console to show the current properties:

image image image

acosta-edgar commented 2 months ago

CloudFormation supports AutomaticBackupReplicationKmsKeyId for DbInstance, but cdk does not, and without it there is no use for the automatic backup region parameter: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbinstance.html#cfn-rds-dbinstance-automaticbackupreplicationkmskeyid

Automatic Backup Retention Period is already supported in CDK: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.CfnDBInstance.html#backupretentionperiod

azatoth commented 2 months ago

Automatic Backup Retention Period is already supported

There are two different backup retention periods; I never screenshotted the other retention period but I realize I should have done that. image

Above is the "normal" backup retention period entry. So we can conclude it's meant to be two separate periods; which makes sense.