PatMyron commented 4 years ago

Should be able to tag-on-create and update tags at the system tag-level, stack-level and resource-level for all resource types that support tagging natively without unnecessary resource replacement

Wonder if tagging should be an issue label..

andyjgordon commented 4 years ago

Hi @PatMyron, I don't see AWS::Glue::Crawler in the above list, which I know suffers the same issue (stack-level tags dont get applied). Also suspect AWS::Glue::Workflow and AWS::Glue::Trigger may have the same, but would need to test. Do you want me to create an issue for these?

benkehoe commented 4 years ago

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

benbridts commented 4 years ago

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

But it should be aware of resources that require some interruption or replacement when adding them. Eg. EIP or ElasticBeanstalk Environment

pareddy113 commented 4 years ago

@PatMyron I see the stack level tags not being applied to AWS::EC2::VPCEndpointService as well, do you want me to create an issue for this?

PatMyron commented 4 years ago

@PatMyron I see the stack level tags not being applied to AWS::EC2::VPCEndpointService as well, do you want me to create an issue for this?

https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/350

tvb commented 3 years ago

@PatMyron can you update us if there is any progress being made here?

Maycon-Santos-sm commented 3 years ago

@PatMyron Is this really in progress or is more of a low priority issue?

badaldavda8 commented 3 years ago

644 #645

benbridts commented 3 years ago

652

rgoltz commented 3 years ago

742

yvele commented 3 years ago

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

@benkehoe does your comment covers the fact that explicitly adding Tag to an existing AWS::CloudFront::Distribution does not add the tags (while adding the tags via the console works fine)?

This is not working for an existing distribution:

Distribution:
  Type: AWS::CloudFront::Distribution
  Properties:
    Tags:
      - Key: my-tag-key
        Value: my-tag-value

By the way.. any workaround?

estanqueiroa commented 2 years ago

Please add AWS EMRCluster to this list, CFN stack-level tags are not created. Thank you

CloudFormation automatically creates the following stack-level tags with the prefix aws::

aws:cloudformation:logical-id aws:cloudformation:stack-id aws:cloudformation:stack-name

ayrawat17 commented 1 year ago

1734 :Add support for stack level tags to AWS::EC2::KeyPair

aerle commented 10 months ago

1786

aerle commented 9 months ago

1807

1808

zenttic-aws commented 6 months ago

#19

aerle commented 6 months ago

901

zipkid commented 4 months ago

1934

desikora commented 4 months ago

1939 1940

rgoltz commented 3 weeks ago

aws-cloudformation / cloudformation-coverage-roadmap

Tagging resource type coverage #228

644 #645

652

742

1734 :Add support for stack level tags to AWS::EC2::KeyPair

1786

1807

1808

901

1934

1460

1526