search

aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.
Apache License 2.0
90 stars 38 forks source link

Add property Transform in Uluru Schema to avoid falsely drifted resources #106

Closed anshikg closed 3 years ago

anshikg commented 3 years ago

Issue #, if available: Description of changes: Avoid Falsely drifted resources by adding transformation function for every falsely drifted property

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PatMyron commented 3 years ago

confused by base.definition.schema.v1.json, is that file coming from somewhere else? We only seem to be using a few lines of it, so I'm confused about the rest of it. I think I'd prefer just inlining the few lines we're using than splitting into multiple JSON schemas

looks addressed in https://github.com/aws-cloudformation/aws-cloudformation-resource-schema/pull/107, closing this PR in favor of that one