search

aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.
Apache License 2.0
90 stars 38 forks source link

Set default taggable to false when UpdateHandler not provided #122

Closed Yunhao-Jiao closed 3 years ago

Yunhao-Jiao commented 3 years ago

Issue #, if available: https://github.com/aws-cloudformation/cloudformation-resource-schema/pull/105#discussion_r634834873 Description of changes: As discussed with @PatMyron offline, we need to set the default value of taggable to be false when UpdateHandler is not provided, so that update on stack level tags won't trigger the replace update of the resource.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aygold92 commented 3 years ago

I think we should revert this change, as I commented on #105

the whole issue with lack of update handler is a CFN specific issue, and that is orthogonal to the issue here. A resource can be taggable (i.e., it supports tags) and also not have an update handler. Taggable is true by default because we expect that all resources should support tags