search

aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.
Apache License 2.0
90 stars 38 forks source link

Change the defination of taggable to be non-relavent to update handler #123

Closed Yunhao-Jiao closed 3 years ago

Yunhao-Jiao commented 3 years ago

Issue #, if available: related to #122

Description of changes:

Change the defination of taggable to be non-relavent to update handler

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PatMyron commented 3 years ago

Checked public resource schemas specifying taggable; doesn't look like any would need to change from this change 👍 

CloudformationSchema $ grep '"taggable"' *
aws-backup-backupselection.json:  "taggable" : false,
aws-networkmanager-customergatewayassociation.json:  "taggable" : false,
aws-networkmanager-linkassociation.json:  "taggable" : false,
aws-networkmanager-transitgatewayregistration.json:  "taggable" : false,
aws-route53-dnssec.json:  "taggable" : false,
aws-route53-keysigningkey.json:  "taggable" : false,
aws-servicecatalogappregistry-application.json:  "taggable" : true,
aws-servicecatalogappregistry-attributegroup.json:  "taggable" : true,
aws-servicecatalogappregistry-attributegroupassociation.json:  "taggable" : false,
aws-servicecatalogappregistry-resourceassociation.json:  "taggable" : false,
aws-ses-configurationset.json:  "taggable" : false,
PatMyron commented 3 years ago

We should update documentation as well:

https://github.com/aws-cloudformation/cloudformation-resource-schema/blob/99361c00b4e68f36512df3e34e216b72742289c4/README.md#L39 https://github.com/aws-cloudformation/cloudformation-resource-schema/blob/99361c00b4e68f36512df3e34e216b72742289c4/README.md#L180