fix a NPE with nested writeOnlyProperties with optional parent.

aws-cloudformation / cloudformation-resource-schema

The CloudFormation Resource Schema defines the shape and semantic for resources provisioned by CloudFormation. It is used by provider developers using the CloudFormation RPDK.

Apache License 2.0

90 stars 38 forks source link

fix a NPE with nested writeOnlyProperties with optional parent. #136

Closed bcorman3 closed 2 years ago

bcorman3 commented 2 years ago

Issue #, if available:

Description of changes: Change the removeProperty function to catch NullPointerException, as this implies the parent object was null when removing a nested property. This function is intended to take no action when the property to be removed was null, so it should take no action in this case as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bcorman3 commented 2 years ago

Updated to use optional so we don't swallow any unexpected exceptions.